✅ Review Complete

Code Review for PR #8329

The changes look good overall and properly address the issue of malformed Anthropic payloads. Here are a few observations:

Positive aspects:

1. ✅ Correctly filters out empty text content to prevent malformed payloads
2. ✅ Properly validates that thinking blocks have a signature before including them
3. ✅ Removes the unsafe default empty signature (?? "") which was flagged in TODOs
4. ✅ Consistent filtering approach across both string and array content types

Potential issues to consider:

1. Silent data loss (Lines 161-164, 169-171, 179-181):
   The code now silently drops thinking blocks without signatures and empty content by returning empty arrays. While this prevents malformed payloads, it might hide issues where data is unexpectedly lost. Consider adding a warning log when dropping content:

   if (!signature) {
     console.warn("Dropping thinking block without signature");
     return [];
   }

2. Missing test coverage:
   No test file changes are included. This fix should have tests covering:

   • Empty string content filtering
   • Empty text parts in arrays
   • Thinking blocks without signatures
   • Thinking blocks with empty content

3. Image handling inconsistency (Lines 107-116):
   Images are not filtered for empty/invalid data like text is. Consider whether images should also be validated before being added to the parts array (e.g., checking if part.imageUrl.url exists and is properly formatted).

Suggestion: Add unit tests in core/llm/llms/Anthropic.vitest.ts or Anthropic.test.ts to verify these edge cases are handled correctly.

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

🎉 This PR is included in version 1.27.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀